Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strict mode to utils.setting() #176

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@ZuluPro
Copy link
Contributor

ZuluPro commented Jul 30, 2016

This ease the way to detect a setting and raise an error if unfound.
With tests ;)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 30, 2016

Current coverage is 41.82% (diff: 100%)

Merging #176 into master will increase coverage by 0.17%

@@             master       #176   diff @@
==========================================
  Files            17         17          
  Lines          1311       1315     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            546        550     +4   
  Misses          765        765          
  Partials          0          0          

Powered by Codecov. Last update 29367fd...553ce13

:type strict: bool
:returns: Setting's value
:raises: django.core.exceptions.ImproperlyConfigured if setting is unfound
and stric mode

This comment has been minimized.

Copy link
@jschneier

jschneier Aug 1, 2016

Owner

You typoed the word strict here!

@ZuluPro ZuluPro force-pushed the ZuluPro:setting branch from 1378021 to 553ce13 Aug 1, 2016

@ZuluPro

This comment has been minimized.

Copy link
Contributor Author

ZuluPro commented Aug 1, 2016

@jschneier: Updated !

@jschneier jschneier merged commit c8e902b into jschneier:master Aug 2, 2016

3 checks passed

codecov/patch 100% of diff hit (target 41.64%)
Details
codecov/project 41.82% (+0.17%) compared to 29367fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.