Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error with GZIP settings for Google Storage #51

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@stmos
Copy link

stmos commented Jun 12, 2015

GSBotoStorage inherits from S3BotoStorage.

In S3BotoStorage the gzip variable is called 'gzip' while GSBotoStorage was using is_gzipped.

@jschneier

This comment has been minimized.

Copy link
Owner

jschneier commented Jul 2, 2015

Good catch! It's very annoying that this library was written with all of the settings vars at the class level, that makes it quite hard to mock things out to say the least.

I've opened up a PR at #60 with the same fix as you and a test, hope that's alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.