Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse mixin order, otherwise StorageMixin is ineffective. #63

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Projects
None yet
2 participants
@agriffis
Copy link
Contributor

agriffis commented Jul 14, 2015

StorageMixin is supposed to isolate the new max_length feature to
Django-1.8 and later, but it wasn't actually doing anything because the MRO
is backwards.

Reverse mixin order, otherwise StorageMixin is ineffective.
StorageMixin is supposed to isolate the new `max_length` feature to
Django-1.8 and later, but it wasn't actually doing anything because the MRO
is backwards.

jschneier added a commit that referenced this pull request Aug 14, 2015

@jschneier

This comment has been minimized.

Copy link
Owner

jschneier commented Aug 14, 2015

Thanks! I added a failing test case.

jschneier added a commit that referenced this pull request Aug 14, 2015

Merge pull request #63 from agriffis/mixin-order
Reverse mixin order, otherwise StorageMixin is ineffective.

@jschneier jschneier merged commit 41c546c into jschneier:master Aug 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jschneier added a commit that referenced this pull request Aug 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.