Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use encryption setting for S3BotoStorageFile multipart uploads #94

Merged
merged 1 commit into from Nov 16, 2015

Conversation

Projects
None yet
2 participants
@andersontep
Copy link
Contributor

andersontep commented Nov 11, 2015

S3BotoStorageFile's write method was not initiating the multipart upload with encryption on, even when AWS_S3_ENCRYPTION was True in the settings

@andersontep

This comment has been minimized.

Copy link
Contributor Author

andersontep commented Nov 16, 2015

@jschneier do you mind taking a look when you have a moment? Thank you!

@jschneier

This comment has been minimized.

Copy link
Owner

jschneier commented Nov 16, 2015

This looks good, thanks.

jschneier added a commit that referenced this pull request Nov 16, 2015

Merge pull request #94 from andersontep/s3boto_encryption
use encryption setting for S3BotoStorageFile multipart uploads

@jschneier jschneier merged commit 1ea09b2 into jschneier:master Nov 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jschneier added a commit that referenced this pull request Nov 16, 2015

mbarrien added a commit to mbarrien/django-storages that referenced this pull request Jan 13, 2016

@pyup-bot pyup-bot referenced this pull request Mar 27, 2017

Open

Initial Update #94

@pyup-bot pyup-bot referenced this pull request Aug 12, 2017

Closed

Initial Update #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.