Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Move chronic dependency to Gemfile #74

Closed
wants to merge 3 commits into from

8 participants

@jnimety

it looks like chronic is only used for development/testing, so remove gemspec dependency so it doesn't mess with downstream apps

Signed-off-by: Joel Nimety jnimety@continuity.net

@jnimety jnimety it looks like chronic is only used for development/testing, so remove…
… gemspec dependency so it doesn't mess with downstream apps

Signed-off-by: Joel Nimety <jnimety@continuity.net>
60507b5
@crawlik

How about using s.add_development_dependency("chronic", ["~> 0.3.0"]) ?

@crawlik

No need to add gem 'chronic' and 'rake' in Gemfile according http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

@cgriego

@jscruggs What's the status of this? I can't upgrade to newer versions of gems with fixes I need and keep metric_fu without this fix.

@technicalypto

yep.. me too need to know the status of this and when will a stable version be out?

@crawlik

Guys, please review and merge. tnx

@danmayer

Part of the problem was churn was requiring to specific of a version of main and chronic. I relased 0.0.15 of churn which has 'looser' dependencies and should allow metric_fu to install

Sorry about that.

@danmayer

linking to my other comment, moving to a development_dependency would be great, but we should allow a less restrictive version. like >= 0.3.0

https://github.com/jscruggs/metric_fu/issues/73

@emoreth

Please merge...

@PragTob

Please merge this, it looks like an awesome gem and I bet that many people listening to todays Ruby Rogues podcast will want to try and check it out!

@danmayer

So I made a number of changes to churn to try to fix the chronic depenancy issues, but the change needs to be made in metric_fu.

@rferraz made a fixed version
gem install rferraz-metric_fu from https://github.com/rferraz/metric_fu

I also pulled in nearly all the metric_fu pull requests which gets some nice fixes in and updated the churn requirement to make metric_fu work. It can be found https://github.com/danmayer/metric_fu

gem install danmayer-metric_fu

or Gemfile

group :development, :test do
gem 'danmayer-metric_fu'
end

add to rake file: require 'metric_fu'

bundle exec rake metrics:all

Anyways, I will try to maintain this a little bit until @jscruggs has time to pull things in and make another mainline release.

@bf4 bf4 referenced this pull request in metricfu/metric_fu
Closed

Move chronic dependency to Gemfile #14

@bf4 bf4 referenced this pull request from a commit in bf4/metric_fu
@bf4 bf4 Update Changelog for #74 6a31b7e
@bf4
Collaborator
bf4 commented

Gem no longer maintained, See https://github.com/metricfu/metric_fu

@bf4 bf4 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 22, 2011
  1. @jnimety

    it looks like chronic is only used for development/testing, so remove…

    jnimety authored
    … gemspec dependency so it doesn't mess with downstream apps
    
    Signed-off-by: Joel Nimety <jnimety@continuity.net>
Commits on Aug 23, 2011
  1. @jnimety
  2. @jnimety

    oops, forgot to specify the cronic dependency as development

    jnimety authored
    Signed-off-by: Joel Nimety <jnimety@continuity.net>
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +0 −1  Gemfile
  2. +2 −1  metric_fu.gemspec
View
1  Gemfile
@@ -1,3 +1,2 @@
source "http://rubygems.org"
-gem 'rake'
gemspec
View
3  metric_fu.gemspec
@@ -20,12 +20,13 @@ Gem::Specification.new do |s|
s.add_dependency("reek", [">=1.2.6"])
s.add_dependency("roodi", [">=2.1.0"])
s.add_dependency("rails_best_practices", [">=0.6.4"])
- s.add_dependency("chronic", ["~> 0.3.0"])
s.add_dependency("churn", [">= 0.0.7"])
s.add_dependency("Saikuro", [">= 1.1.0"])
s.add_dependency("activesupport", [">= 2.0.0"])
s.add_dependency("syntax")
+ s.add_development_dependency("rake")
+ s.add_development_dependency("chronic", ["~> 0.3.0"])
s.add_development_dependency("rspec", ["= 1.3.0"])
s.add_development_dependency("test-construct", [">= 1.2.0"])
s.add_development_dependency("googlecharts")
Something went wrong with that request. Please try again.