This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
Remove grunt-bump #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2. Run a bump script via npm. This will commit and tag the changed files: | ||
| - `npm run bump` - will increase the patch version; | ||
| - `npm run bump-minor` - will increase the minor version. | ||
| 3. Push changes and tags: `git push --follow-tags` |
There was a problem hiding this comment.
Nice, should update jscs docs too.
/cc @mikesherov
|
Yey! |
|
Another thing I noted is that package.json will lose its current indentation style. |
Yeah, i guess there is no way around it, npm forces it, we probably should add this format for |
Due to the change presented in de383ba, we will now use the npm version tool to modify our version property automatically. Because npm doesn't respect the current indentation of the package.json file, we have to follow their rules and indent with 2 spaces as well.
|
Are we good to merge? |
|
Yeah! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markelog, feedback please?
npm version patchornpm version minor. I created the npm scripts because that allows to keep the same commit message style.vprefix, unless we settag-version-prefixconfig, but that's another factor to increase complexity of the bump process.Closes #87