From 47d19e1a0dc7f35ec0b8c50af4e35eaf1291b9cb Mon Sep 17 00:00:00 2001 From: Oleg Gaidarenko Date: Thu, 14 Jul 2016 03:31:53 +0300 Subject: [PATCH] validateParameterSeparator: notice class methods Fixes #2289 --- lib/rules/validate-parameter-separator.js | 6 +++++- .../rules/validate-parameter-separator.js | 20 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/rules/validate-parameter-separator.js b/lib/rules/validate-parameter-separator.js index fd01038a5..2b9129431 100644 --- a/lib/rules/validate-parameter-separator.js +++ b/lib/rules/validate-parameter-separator.js @@ -54,7 +54,11 @@ module.exports.prototype = { var whitespaceBeforeComma = Boolean(separators.shift()); var whitespaceAfterComma = Boolean(separators.pop()); - file.iterateNodesByType(['FunctionDeclaration', 'FunctionExpression'], function(node) { + file.iterateNodesByType([ + 'FunctionDeclaration', + 'FunctionExpression', + 'ClassMethod' + ], function(node) { node.params.forEach(function(paramNode) { diff --git a/test/specs/rules/validate-parameter-separator.js b/test/specs/rules/validate-parameter-separator.js index 67a56aec0..2fd031fcc 100644 --- a/test/specs/rules/validate-parameter-separator.js +++ b/test/specs/rules/validate-parameter-separator.js @@ -51,6 +51,11 @@ describe('rules/validate-parameter-separator', function() { .to.have.one.validation.error.from('validateParameterSeparator'); }); + it('should validate class methods', function() { + expect(checker.checkString('class a { constructor(a, b) {} }')) + .to.have.one.validation.error.from('validateParameterSeparator'); + }); + it('should report unexpected space for function a(b ,c) {}', function() { expect(checker.checkString('function a(b ,c) {}')) .to.have.one.validation.error.from('validateParameterSeparator'); @@ -102,6 +107,11 @@ describe('rules/validate-parameter-separator', function() { .to.have.one.validation.error.from('validateParameterSeparator'); }); + it('should validate class methods', function() { + expect(checker.checkString('class a { constructor(a , b) {} }')) + .to.have.one.validation.error.from('validateParameterSeparator'); + }); + it('should report missing space for function a(b,c) {}', function() { expect(checker.checkString('function a(b,c) {}')) .to.have.one.validation.error.from('validateParameterSeparator'); @@ -149,6 +159,11 @@ describe('rules/validate-parameter-separator', function() { .to.have.one.validation.error.from('validateParameterSeparator'); }); + it('should validate class methods', function() { + expect(checker.checkString('class a { constructor(a , b) {} }')) + .to.have.one.validation.error.from('validateParameterSeparator'); + }); + it('should report missing space for function a(b,c) {}', function() { expect(checker.checkString('function a(b,c) {}')) .to.have.one.validation.error.from('validateParameterSeparator'); @@ -192,6 +207,11 @@ describe('rules/validate-parameter-separator', function() { .to.have.one.validation.error.from('validateParameterSeparator'); }); + it('should validate class methods', function() { + expect(checker.checkString('class a { constructor(a, b) {} }')) + .to.have.one.validation.error.from('validateParameterSeparator'); + }); + it('should report missing space for function a(b ,c) {}', function() { expect(checker.checkString('function a(b ,c) {}')) .to.have.one.validation.error.from('validateParameterSeparator');