This repository has been archived by the owner. It is now read-only.

"disallowCommaBeforeLineBreak": { "allExcept": [ "function" ] } does not work #1841

Closed
tellnes opened this Issue Oct 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tellnes

tellnes commented Oct 5, 2015

jscs -V
2.2.1

disallowCommaBeforeLineBreak: Error running rule disallowCommaBeforeLineBreak: This is an issue with JSCS and not your codebase.
Please file an issue (with the stack trace below) at: https://github.com/jscs-dev/node-jscs/issues/new
TypeError: Cannot read property 'some' of undefined
    at canSkip (/usr/local/lib/node_modules/jscs/lib/rules/disallow-comma-before-line-break.js:90:53)
    at /usr/local/lib/node_modules/jscs/lib/rules/disallow-comma-before-line-break.js:96:17
    at /usr/local/lib/node_modules/jscs/lib/js-file.js:603:17
    at Array.forEach (native)
    at Object.JsFile.iterateTokensByTypeAndValue (/usr/local/lib/node_modules/jscs/lib/js-file.js:601:26)
    at Object.module.exports.check (/usr/local/lib/node_modules/jscs/lib/rules/disallow-comma-before-line-break.js:95:14)
    at null.<anonymous> (/usr/local/lib/node_modules/jscs/lib/string-checker.js:165:22)
    at Array.forEach (native)
    at StringChecker._checkJsFile (/usr/local/lib/node_modules/jscs/lib/string-checker.js:161:31)
    at StringChecker.checkString (/usr/local/lib/node_modules/jscs/lib/string-checker.js:106:14) at rules/browserify._js :

I belive cd8ce2e is responsible.

@hzoo hzoo added the bug label Oct 5, 2015

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 5, 2015

Member

If it is then it might be the same as #1746? @dreef3

Can you post a code snippet that would result in the error? Thanks for the report!

Member

hzoo commented Oct 5, 2015

If it is then it might be the same as #1746? @dreef3

Can you post a code snippet that would result in the error? Thanks for the report!

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 7, 2015

Member

Ok we're going to release 2.3.0 soon

Member

hzoo commented Oct 7, 2015

Ok we're going to release 2.3.0 soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.