This repository has been archived by the owner. It is now read-only.

Version 3.0 #1854

Closed
mdevils opened this Issue Oct 8, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@mdevils
Member

mdevils commented Oct 8, 2015

This is a roadmap ticket for version 3.0 which we are starting to work on intensively today.

The master branch is now for the new 3.0 version. For 2.x-hotfixes we now have 2.x branch.

CST (WIP PR: #1977) (Merged #2101)

The 3.0 version consists of:

  • Using CST for checking.
  • Using CST for fixing.
  • Deprecating most of JsFile functions (they are duplicative to CST).
  • Operating using elements instead of line, column in error reporting.
  • Document what is considered a public API (#1084, #1821)
  • Fixup skipped tests/all tests pass
  • Fix TODO comments

CLI

  • --verbose = true by default (so easier to debug issue by rule name) - #1522
  • Update the internal error message to supply version number, debug info, sample code, etc
  • Remove esnext, es6, esprima, esprimaOptions values (on by default / use cst) #2102 #2103 #2104

Deprecations

  • remove deprecated (JSX) XJS visitors
  • remove all *deprecated* options #2110
  • remove all options that aren't allExcept: {} and replace them with allExcept

Wishlist

  • [ ] Rewrite in ES6 (#1469)
  • [ ] Perf metrics on rules, parsing, file handling, etc #1043
  • A way to create an issue from the cli (with issue template or automated)

Config Wishlist

  • [ ] New structure - #698
  • [ ] Provide option for config rewrite (basically a command to upgrade a users config from 2.x to 3 automatically so there's a simple upgrade path, same with deprecated)
  • Rules rename - #1834
  • Use json schema for rule input validation - #480

/cc @markelog @hzoo @zxqfox @mrjoelkemp @mikesherov

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Oct 8, 2015

Member

What is the progress on those points?

Using CST for fixing.

Can we leave some parts on token manipulating? I think no, right?

Would you mind providing examples for #3 and #4 points? How it was and how it should be? So others could duplicate that

Member

markelog commented Oct 8, 2015

What is the progress on those points?

Using CST for fixing.

Can we leave some parts on token manipulating? I think no, right?

Would you mind providing examples for #3 and #4 points? How it was and how it should be? So others could duplicate that

@hzoo hzoo added this to the 3.0 milestone Oct 8, 2015

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 8, 2015

Member

Can check the 3.0 milestone for anything else we want to do or postpone. I think we can also do RC versions to allow users (and ourselves) to test it out (rc for rule rename, rc for config rewrite, rc for cst integration, etc)

Member

hzoo commented Oct 8, 2015

Can check the 3.0 milestone for anything else we want to do or postpone. I think we can also do RC versions to allow users (and ourselves) to test it out (rc for rule rename, rc for config rewrite, rc for cst integration, etc)

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 10, 2015

Member

Even if we don't get to the new format structure soon - we can try to combine rules that are similar - like maybe the function spacing rules? Clarified some of the options

Member

hzoo commented Oct 10, 2015

Even if we don't get to the new format structure soon - we can try to combine rules that are similar - like maybe the function spacing rules? Clarified some of the options

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 13, 2015

Member

Added deprecations, and documenting what is a public API

Member

hzoo commented Oct 13, 2015

Added deprecations, and documenting what is a public API

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.