Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define runtime "_" in configuration file #80

Merged
merged 2 commits into from Mar 16, 2012

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented Jan 5, 2012

Related to #79

@rafalwrzeszcz
Copy link
Contributor

Well, I was the one to implement merging of runtime and conffile options and I left this case without solution because of such... not very elegant solutions :).

I see the need of such feature, but I'm not fully convinced by your path... the problem is that console options module pre-defines _ argument as empty array, so it's always present. Maybe we should merge them instead?

But if noone else sees the problem, then nevermind my comment, I have nothing against that, just pure elegancy :).

@tomalec
Copy link
Contributor Author

tomalec commented Jan 6, 2012

You're right, it's not so elegant.

It was first, simplest solution for my problem, but merging those arrays seems much nicer.

@tomalec
Copy link
Contributor Author

tomalec commented Jan 26, 2012

Do you think it's nicer?
BTW. I wasn't sure. Does order of files in _ makes any difference?

@rafalwrzeszcz
Copy link
Contributor

Sure, a lot more elegant :).

Order of files can only change the order of occurance of entities with same name in resultet documentation - all source files are first scanned for symbols, symbols are not aware of code dependencies, also in JSDoc3 names don't collide since documentation is generated for all symbols (even with repeated names).

jannon added a commit that referenced this pull request Mar 16, 2012
Allow to define runtime "_" in configuration file
@jannon jannon merged commit 55d2b2c into jsdoc:master Mar 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants