Skip to content

Add a test expectations file for to-upstream tests #3835

Closed

Description

@domenic

Sometimes when investigating issues tagged "maybe fixed (add tests to confirm)", I write a test and find that it fails. At that point, there's nothing in the current project that is set up to accept that test, so we just throw it away and the investigation progress is lost.

Instead, we should have a list (similar to the to-upstream.yml file) which lists expected-failing to-upstream tests. Then I can check in failing to-upstream tests, and we can use them to track the issues.

The existing field for comments should always contain a jsdom issue in this file, probably.

Activity

  1. added a commit that references this issue on Mar 24, 2025
    a2b7c22
  2. asamuzaK commented on Mar 30, 2025

    @asamuzaK
    Contributor

    FYI, I have some regression tests for jsdom/issues
    https://github.com/asamuzaK/domSelector/tree/main/test/wpt/jsdom/issues
    Feel free to copy and use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metr upliftA candidate for the METR Uplift experiment

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions