Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement Web storage - localStorage, sessionStorage, StorageEvent #2076
This is a work-in-progress implementation of the
All the tests for storing data are currently passing, but some of the event tests will require further work. I welcome feedback at this stage, but keep in mind that this is not yet complete.
(Also, thank you @TimothyGu for making this a breeze to implement through all your improvements to webidl2js!)
This is now ready for review
EDIT: I just had a careful read through the spec and noticed that I've overlooked a detail about separate objects. I'll have another go at completing this next week.
It would appear that one of the tests is using
I had time to do some further testing of my own today and found more cases not covered by the existing tests. These include making sure that data is shared between a parent and several iframes within the same origin, as well as checking that the
I've fixed the former issue, getting some neat refactoring done in the process. The latter issue is only partially resolved at the moment - manipulations done on a parent window will no longer cause the
Considering this and some gaps in the test coverage I found earlier I'm now hesitant to merge this without writing several new tests, so this could take a while longer to complete.