Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x, y parameters to getBoundingClientRect #3187

Merged
merged 2 commits into from Jun 19, 2021
Merged

Conversation

eikobear
Copy link
Contributor

@eikobear eikobear commented May 10, 2021

getBoundingClientRect returns a DOMRect which is supposed to have an x and y property. This change makes getBoundingClientRect behave more reliably for code which expects its properties to have defined numerical values.

fixes #3188

@domenic
Copy link
Member

domenic commented May 22, 2021

Although the general plan for these not-very-good mocks is still up in the air (see #2751), this seems like a reasonable improvement assuming CI passes, so I'll merge it pending further discussion on that point.

@domenic domenic self-assigned this May 22, 2021
@domenic
Copy link
Member

domenic commented May 23, 2021

Looks like this requires a few test updates.

@domenic domenic removed their assignment May 23, 2021
@eikobear
Copy link
Contributor Author

eikobear commented Jun 16, 2021

@domenic sorry for the delay on this- I had trouble getting tests to run locally.

I updated the "build" tests so they should pass now, but I couldn't figure out why "build-with-canvas" was failing with a segmentation fault. Let me know if this is expected, or if there is further action that needs to be done on my part.

@TimothyGu TimothyGu merged commit c9896c0 into jsdom:master Jun 19, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBoundingClientRect is missing x, y parameters
3 participants