Skip to content

Support indexed properties on HTMLFormElement - #3849

Merged
domenic merged 2 commits into
mainfrom
form-indexed-getter
Mar 30, 2025
Merged

Support indexed properties on HTMLFormElement#3849
domenic merged 2 commits into
mainfrom
form-indexed-getter

Conversation

@domenic

@domenic domenic commented Mar 30, 2025

Copy link
Copy Markdown
Member

Closes #3616.

@domenic

domenic commented Mar 30, 2025

Copy link
Copy Markdown
Member Author

Implementation report: this was relatively fine without AI, taking 25 minutes. Most of the time was spent re-familiarizing myself with the webidl2js infrastructure and the relevant parts of the spec, which AI wouldn't have necessarily helped much with.

I spent 10 of those minutes trying to implement the named getter too, but got confused when browsers don't seem to match the spec for Object.getOwnPropertyNames() with named properties. (Reported as whatwg/html#11174.) So I decided to just tie it off and implement only the original feature request.

@domenic
domenic merged commit 3398cf4 into main Mar 30, 2025
@domenic
domenic deleted the form-indexed-getter branch March 30, 2025 11:26
@domenic domenic added the metr uplift A candidate for the METR Uplift experiment label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metr uplift A candidate for the METR Uplift experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement HTMLFormElement indexed getter

1 participant