Add disableCSS option - #3861
Closed
domenic wants to merge 1 commit into
Closed
Conversation
Closes #2005.
Member
Author
|
Implementation report: this was relatively painful without AI, in that I just really missed having a solid autocomplete. There was a medium amount of design work which I anticipate AI wouldn't have helped with, but there was also a lot of turning the crank on test code that was very similar to nearby test code. Even writing the documentation would have been nicer with autocomplete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2005.
I am going to close this PR immediately and not attempt to merge it because I cannot find any evidence that skipping CSS processing gives any performance benefits. See the full discussion in #2005 (comment). But, I wanted to create the PR for the record, and to make it easier to resurrect if we get some evidence that it's helpful.
If this were to be resurrected, probably the README needs more detail on the impacts (e.g.
getComputedStyle(),.sheet,.style), based on the test suite.