Re-do jsdom errors in the virtual console - #3866
Merged
Merged
Conversation
* Rename sendTo() to forwardTo(). This helps people realize the method now has new semantics.
* Changed from { omitJSDOMErrors: true } to { jsdomErrors } which can be undefined, "none", or a list of jsdom error types to forward.
* Changed and consolidated error types and properties, from their previous undocumented form (usually a type and a detail) into a well-documented form with more structured properties.
* Stopped emitting jsdom errors for failed XHRs, similar to how browsers no longer display those in the console.
* Generally expanded test coverage for the jsdom errors.
Closes #3596.
Member
Author
|
Implementation report: It was definitely nice to have AI for this task. I was using Cursor, but mostly in tab-complete mode. For this sort of situation where I was doing a lot of updating from the old style to the new, or renaming things, tab-complete mode was great. In particular it was good (but not perfect) at anticipating what the next change I wanted to make was. I briefly used the agent mode, with gemini-2.5-pro-exp-03-25, to adapt some old tests to the new API. |
This was referenced Sep 17, 2025
pilafmon
added a commit
to center-key/fetch-json
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename sendTo() to forwardTo(). This helps people realize the method now has new semantics.
Changed from { omitJSDOMErrors: true } to { jsdomErrors } which can be undefined, "none", or a list of jsdom error types to forward.
Changed and consolidated error types and properties, from their previous undocumented form (usually a type and a detail) into a well-documented form with more structured properties.
Stopped emitting jsdom errors for failed XHRs, similar to how browsers no longer display those in the console.
Generally expanded test coverage for the jsdom errors.
Closes #3596.