Roll webidl2js and add a test for the defineProperty bug - #3868
Merged
Conversation
Member
Author
|
Implementation report: (Note that the more important work happened in jsdom/webidl2js#272.) This was slightly annoying to do without AI, but was not that hard of a task regardless. Some of the refactorings and cleanups could have benefited from autocomplete. And I might have been tempted to use AI to generate the test case, but I think that would have taken more time than just typing it out manually. Similarly I might have been tempted to tell AI "look at the spec and fix my implementation", but it was pretty quick to just put the spec on the other monitor and fix the implementation manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3565.