Explained the use of config.url in the README and added contextual resolution of image src attributes #470

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@brianmaissy
Contributor

brianmaissy commented Jul 17, 2012

It was unclear how to control what url jsdom uses to resolve anchor href attributes, so I clarified in the README.

I also found that it would be useful if jsdom treated image src attributes the same way (I was manually resolving the relative 'src's of all my images), so I added that functionality. If this was not included yet intentionally, maybe it should be configurable. But if the default for anchors is to automatically resolve 'href's, I figured by analogy this would be the correct default.

@brianmaissy

This comment has been minimized.

Show comment Hide comment
@brianmaissy

brianmaissy Jul 17, 2012

Contributor

Whoops, just realized that in my excitement I forgot to run the tests. 18 tests were failing in the level2/html suite on HEAD before my changes. My change broke one, so I updated the test to reflect the new functionality. Now only 18 tests failing again.

Contributor

brianmaissy commented Jul 17, 2012

Whoops, just realized that in my excitement I forgot to run the tests. 18 tests were failing in the level2/html suite on HEAD before my changes. My change broke one, so I updated the test to reflect the new functionality. Now only 18 tests failing again.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Oct 5, 2012

Owner

This looks valuable. Would you like to update it, now that all the tests are passing, and squash/rebase against master?

Owner

domenic commented Oct 5, 2012

This looks valuable. Would you like to update it, now that all the tests are passing, and squash/rebase against master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment