Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Explained the use of config.url in the README and added contextual resolution of image src attributes #470
It was unclear how to control what url jsdom uses to resolve anchor href attributes, so I clarified in the README.
I also found that it would be useful if jsdom treated image src attributes the same way (I was manually resolving the relative 'src's of all my images), so I added that functionality. If this was not included yet intentionally, maybe it should be configurable. But if the default for anchors is to automatically resolve 'href's, I figured by analogy this would be the correct default.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Whoops, just realized that in my excitement I forgot to run the tests. 18 tests were failing in the level2/html suite on HEAD before my changes. My change broke one, so I updated the test to reflect the new functionality. Now only 18 tests failing again.