Skip to content

Fix generated set trap for proxy cases - #272

Merged
domenic merged 1 commit into
mainfrom
defineproperty-fix
Apr 20, 2025
Merged

Fix generated set trap for proxy cases#272
domenic merged 1 commit into
mainfrom
defineproperty-fix

Conversation

@domenic

@domenic domenic commented Apr 20, 2025

Copy link
Copy Markdown
Member

@domenic
domenic merged commit 6a93a61 into main Apr 20, 2025
@domenic
domenic deleted the defineproperty-fix branch April 20, 2025 10:19
@dverbru

dverbru commented May 16, 2025

Copy link
Copy Markdown

Is this going to be included in the next jsdom v26 patch release? Thank you

@domenic

domenic commented May 17, 2025

Copy link
Copy Markdown
Member Author

It is automatically; jsdom uses ^ in its version specifiers so any installations automatically get patch version updates.

@dverbru

dverbru commented May 20, 2025

Copy link
Copy Markdown

@domenic jsdom 26.1.0 does not seem to have a dependency on this library.

@domenic

domenic commented May 20, 2025

Copy link
Copy Markdown
Member Author

You're right, it's in the build step. But the good news is that jsdom 26.1.0 was built with the version 18.0.0, so the regression in 18.0.1 which this commit fixes never made it into jsdom.Sorry, I got confused between this and 3810c13.

This will not be included in jsdom 26.x releases, as we're working on the 27.x line now.

@dverbru

dverbru commented May 21, 2025

Copy link
Copy Markdown

Since my first question, v27 has been released, so I upgrade to that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTMLSelectElement won't work with Object.defineProperty: TypeError: 'set' on proxy: trap returned falsish for property <name>

2 participants