New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we (and to what extent) support themeable output #14

Open
webchick opened this Issue Mar 13, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@webchick
Copy link

webchick commented Mar 13, 2018

In Drupal, there is support for overriding markup / CSS coming from a theme, and/or massaging data prior to it being output, on a pretty granular basis (only for these content types, etc.).

We need to figure out if, and if so how, we support this concept from the React application.

@dawehner

This comment has been minimized.

Copy link
Contributor

dawehner commented Mar 13, 2018

I hope we avoid the complexity of making the admin UI themable. I mean its not impossible at all, both @drpal and myself did experiments. Avoiding another layer of complexity though, at least for me, would help to build a good experience.

@pixelmord

This comment has been minimized.

Copy link

pixelmord commented Mar 31, 2018

I would not consider making the Admin UI themable in the sense of overriding markup and other complex alterations that one can do with the Drupal theme system.

However, for the sake of code quality and consistency of e.g. colors and other CSS values, I would propose using the concept of a default emotion theme (https://emotion.sh/docs/theming) to make some common values variables and be able to reuse them across different components style declarations (think error color and an SCSS variables file)

@dawehner

This comment has been minimized.

Copy link
Contributor

dawehner commented Mar 31, 2018

I really like this idea of emotion themes. I think that way we could also introduce some easy way to improve accessibility, similar to what OSX does: Even more contrast, bigger fonts, less animations etc.

@dawehner

This comment has been minimized.

Copy link
Contributor

dawehner commented Nov 22, 2018

I think its fine to summarize that the various discussions we had resulted us in having extension points , but not in a themability way. When people need to dramatically adapt the appearance we'll recommend them to work the app and reuse our components partially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment