New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to destroy reports via the analytics API #568

Merged
merged 2 commits into from Dec 20, 2016

Conversation

Projects
None yet
2 participants
@pcon
Contributor

pcon commented Nov 22, 2016

I tried to follow as much prior art as possible. I wasn't sure how to add a test for this so I didn't. If you have any documentation on writing a test for it I'd be happy to do so.

@stomita

This comment has been minimized.

Show comment
Hide comment
@stomita

stomita Nov 22, 2016

Contributor

@pcon You can setup your own test environment from here https://github.com/jsforce/jsforce/blob/master/test/SETUP.md
By the way, the destroying test is difficult to be done properly. You can implement also cloning and try destroying the cloned afterward.

Contributor

stomita commented Nov 22, 2016

@pcon You can setup your own test environment from here https://github.com/jsforce/jsforce/blob/master/test/SETUP.md
By the way, the destroying test is difficult to be done properly. You can implement also cloning and try destroying the cloned afterward.

@pcon

This comment has been minimized.

Show comment
Hide comment
@pcon

pcon Dec 7, 2016

Contributor

I've added the ability to clone a report and added testing for both the clone functionality and for the destroy functionality.

Contributor

pcon commented Dec 7, 2016

I've added the ability to clone a report and added testing for both the clone functionality and for the destroy functionality.

@pcon

This comment has been minimized.

Show comment
Hide comment
@pcon

pcon Dec 16, 2016

Contributor

@stomita do the included tests match your expectations?

Contributor

pcon commented Dec 16, 2016

@stomita do the included tests match your expectations?

@stomita stomita added the pr:reviewed label Dec 20, 2016

@stomita stomita merged commit 4ee879d into jsforce:master Dec 20, 2016

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment