New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP/2 #189

Open
jsha opened this Issue May 23, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@jsha
Owner

jsha commented May 23, 2015

This is mostly working in the http2 branch. The missing piece is that connection keepalive keeps processes running when they should exit.

@jsha

This comment has been minimized.

Show comment
Hide comment
@jsha

jsha May 24, 2015

Owner

Tried this, got a number of errors after running for a few minutes:


events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: stream.push() after EOF
    at readableAddChunk (_stream_readable.js:146:15)
    at Connection.Readable.push (_stream_readable.js:127:10)
    at Connection._parentPush (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:243:32)
    at Connection._push (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:254:17)
    at Connection.push (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:285:23)
    at Connection._receivePing (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:528:10)
    at Connection.EventEmitter.emit (events.js:95:17)
    at Connection._writeControlFrame (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:128:10)
    at Connection._receive (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:372:19)
    at Connection._write (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:101:10)

I suspect this is due to the server-side (Twitter) closing the connection after some amount of time or number of connections has passed, plus missing client-side socket error handling: molnarg/node-http2#56

Owner

jsha commented May 24, 2015

Tried this, got a number of errors after running for a few minutes:


events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: stream.push() after EOF
    at readableAddChunk (_stream_readable.js:146:15)
    at Connection.Readable.push (_stream_readable.js:127:10)
    at Connection._parentPush (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:243:32)
    at Connection._push (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:254:17)
    at Connection.push (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:285:23)
    at Connection._receivePing (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:528:10)
    at Connection.EventEmitter.emit (events.js:95:17)
    at Connection._writeControlFrame (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:128:10)
    at Connection._receive (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/connection.js:372:19)
    at Connection._write (/data/blocktogether/releases/20150523215549/node_modules/node-twitter-api/node_modules/oauth/node_modules/http2/lib/protocol/flow.js:101:10)

I suspect this is due to the server-side (Twitter) closing the connection after some amount of time or number of connections has passed, plus missing client-side socket error handling: molnarg/node-http2#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment