New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream should check for past actions before enqueuing #194

Open
jsha opened this Issue May 27, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@jsha
Owner

jsha commented May 27, 2015

Right now, each time stream.js starts up, it reviews recent mentions and applies blocks as appropriate. For cases where the BtUsers follows the mentioner, those blocks are then cancelled by actions.js. However, this is unnecessarily wasteful of resources, and fills up the user-visible Actions list with cancelled actions, which are confusing.

Instead, when stream.js gets a mention, it should check whether there is any past action towards the mentioner, and not enqueue any action if there was. This replaces a write, read, write pattern with a read pattern, improving performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment