Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 31, 2011
  1. @valueof

    Merge branch 'es5-duplicate-accessors' of…

    valueof authored
    …Kluge/jshint into WolfgangKluge-es5-duplicate-accessors
Commits on Dec 30, 2011
  1. @valueof
  2. @valueof
  3. @WolfgangKluge

    Extend pull request #401

    WolfgangKluge authored
    Remove "Don't make functions within a loop." on getters.
    It's only thrown on getters and thus not consistent. Since it's not
    thrown on setters nor on simple object properties, I removed it here.
    Don't force "value" as parameter name of setters (see #373).
    Extend tests (coverage).
Commits on Dec 28, 2011
  1. @WolfgangKluge
Commits on Dec 26, 2011
  1. @valueof

    Fixed a typo in a comment doc

    valueof authored
  2. @valueof

    Correctly identify duplicate object properties.

    valueof authored
    JSHint was incorrectly identifying duplicate properties because of
    numerous unsafe assumptions such as that setters always follow getters
    and others.
    This patch removes these assumptions and makes sure that we understand
    that 'get x, set x is okay' but 'get x, x' is not.
    + Tests for duplicate members and a regression test for the
      aforementioned bug.
    This is a response to #382 and a faulty merge
  3. @valueof

    Revert "Merge pull request #382 from fmate14/getset" because tests we…

    valueof authored
    …re breaking.
    This reverts commit 63382c7, reversing
    changes made to 5aa015e.
Commits on Dec 24, 2011
  1. @valueof

    Merge pull request #382 from fmate14/getset

    valueof authored
    Do not allow to duplicate a setter.
  2. @valueof

    Merge pull request #385 from WolfgangKluge/383-regexdash

    valueof authored
    Fix for #383 (option regexdash)
  3. @valueof

    Fixed a typo, oops

    valueof authored
  4. @valueof
Commits on Dec 14, 2011
  1. @WolfgangKluge
  2. Do not allow to duplicate a setter.

    Máté FARKAS authored
Commits on Dec 9, 2011
  1. @valueof

    Change how JSHint treats ES5 accessors.

    valueof authored
    Don't require getter *and* setter, but show a warning when setter
    is used without a corresponding getter.
    Fixes GH-373
    Fixes GH-374
  2. @valueof

    Merge pull request #375 from rondevera/fix-comma-in-members-list

    valueof authored
    Add missing comma in members list
  3. @valueof
  4. @goatslacker @valueof
  5. @valueof

    Merge pull request #378 from dominicbarnes/master

    valueof authored
    Adding "provides" as a global member of the CouchDB environment
  6. @valueof

    Merge pull request #371 from goatslacker/GH-369

    valueof authored
    Fixes a typo in tests and refactors code per valid JSHint report (fixes GH-369)
Commits on Dec 7, 2011
  1. adding 'provides' to 'couch' env

    Dominic Barnes authored
Commits on Dec 5, 2011
  1. @rondevera
Commits on Nov 29, 2011
  1. @goatslacker
  2. @goatslacker
  3. @valueof
  4. @valueof

    Option `smarttabs` to allow the use of SmartTabs

    valueof authored
    This commit adds a new option to JSHint called `smarttabs`. When
    enabled it makes JSHint tolerate tabs followed by spaces (spaces
    followed by tabs are prohibited no matter what). When disabled
    (default) JSHint will warn about any occurence of mixed tabs and
    Refs GH-314 and GH-355.
    Thanks to Maël Nison <> for the initial patch.
Commits on Nov 28, 2011
  1. @valueof

    Put generated files into a build directory.

    valueof authored
    All generated files will now be placed in a `build` directory (ignored
    in the repo). I've also added make clean to empty `build` when needed.
    Renamed `env/jshint-rhino.js` to `env/rhino.js` because the 'jshint-'
    part seemed redundant.
  2. @goatslacker @valueof

    Adds a Makefile that builds jshint-rhino

    goatslacker authored valueof committed
    * Removes load(jshint) from jshint-rhino since JSHint
      is included when `make rhino` is executed.
    * Also adds method test to Makefile which runs tests
      using expresso.
  3. @aparajita @valueof

    Quit parsing after unclosed regular expression.

    aparajita authored valueof committed
    There is a bug when JSHint returns invalid data after unclosed
    regular expression (such as simple `/`). Trivial fix includes
    returning `it('(regexp)', c)` on L1388 but that produces
    a couple of redundant errors such as `Missing semicolon.`, etc.
    This patch makes JSHint quit it work after encountering an
    unclosed regular expression--we can't process a file without
    making mistakes after that anyway.
  4. @goatslacker @valueof

    Include raw property in the 'Too many errors.' message.

    goatslacker authored valueof committed
  5. @goatslacker @valueof

    Show a warning on ambigious returns. Fixes #332.

    goatslacker authored valueof committed
Commits on Nov 27, 2011
  1. @goatslacker
  2. @valueof
  3. @goatslacker @valueof

    Accumulate all undef errors to be processed at the very end.

    goatslacker authored valueof committed
    This approach makes sure that errors caused by undef are not in
    the way of other options such as latedef. The code pushes all
    warning about undefined variables into an array and at the
    end of processing checks if any of those variables were defined
    later in the code and can be legally used due to hoisting.
    Fixes GH-133.
    Fixes GH-347.
    P.S. The only thing is that it can mess up the maxerr option but
    we need to refactor it anyway.
  4. @goatslacker @valueof

    Removed unneccessary call to nospace from functionparams.

    goatslacker authored valueof committed
    This call was producing duplicate whitespace errors as reported in
    Closes GH-351.
Something went wrong with that request. Please try again.