Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an error when yield statement used within a catch block inside a generator function #1543

Merged
merged 1 commit into from Mar 21, 2014

Conversation

hiddentao
Copy link
Contributor

This fixes this issue and adds a parser unit test to ensure it stays fixed.

See #1505

@fengmk2
Copy link

fengmk2 commented Mar 7, 2014

+1 Need this too.

@chanukov
Copy link

👍 please let this get in with next release asap.

@rwaldron
Copy link
Member

I don't understand "+1" when this isn't a "feature request" that's up for discussion, it's just a bug that needs to be fixed.

@valueof
Copy link
Member

valueof commented Mar 21, 2014

Thanks! Can you make the same PR for master as well, please?

valueof added a commit that referenced this pull request Mar 21, 2014
Don't throw an error when yield statement used within a catch block inside a generator function
@valueof valueof merged commit e3aa718 into jshint:2.x Mar 21, 2014
hiddentao added a commit to hiddentao/jshint that referenced this pull request Mar 29, 2014
@hiddentao hiddentao deleted the yield_catch branch March 29, 2014 02:45
@hiddentao
Copy link
Contributor Author

@antonkovalyov PR for master raised in #1596

jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014
Don't throw an error when yield statement used within a catch block inside a generator function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants