New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System errors should have scope too #714

Closed
valueof opened this Issue Oct 25, 2012 · 0 comments

Comments

Projects
None yet
1 participant
@valueof
Copy link
Member

valueof commented Oct 25, 2012

Right now we don't add any scope to system errors such as "Too many errors." one. This is inconsistent with all other error objects and should be fixed.

@ghost ghost assigned valueof Oct 25, 2012

@valueof valueof closed this in ee77638 Oct 27, 2012

jugglinmike added a commit to jugglinmike/jshint that referenced this issue Oct 21, 2014

Add 'scope' property to critical errors.
Critical errors (those produced by the 'quit' function) show up
in JSHINT.data() as well as any other errors and warnings and
should have the same format.

This patch adds a missing property 'scope' to such errors. It's
always set to '(main)' since errors are unrecoverable.

Fixes jshintGH-714.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment