New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.jshintrc search skips every other dir #850

Closed
moos opened this Issue Feb 8, 2013 · 0 comments

Comments

Projects
None yet
2 participants
@moos

moos commented Feb 8, 2013

Running jshint without a --config param is supposed to search for .jshintrc from CWD up to root. However, it skips every other directory.

Culprit: findFile in src/cli/cli.js

var parent = path.resolve(dir, "../../");

Tested in v1.0.0

@valueof valueof closed this in 9c88434 Feb 28, 2013

jugglinmike added a commit to jugglinmike/jshint that referenced this issue Oct 21, 2014

Don't skip directories when searching for .jshintrc.
Instead of moving on to the parent directory when a .jshintrc
file was not found, the cli script was checking the
'grandparent' directory. A test was added to demonstrate the
issue / prevent regressions.

References:
    Fixes jshintGH-850

danielctull pushed a commit to danielctull-forks/jshint that referenced this issue Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment