New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve identifier parser #1297

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mathiasbynens
Contributor

mathiasbynens commented Oct 6, 2013

This patch adds a script to generate the Unicode data needed for identifier parsing. It also greatly improves the identifier parser that is part of the lexer. Previously, things like U+200C and U+200D and symbols in the Unicode categories “Non-spacing mark (Mn)”, “Spacing combining mark (Mc)”, “Decimal digit number (Nd)”, or “Connector punctuation (Pc)” in IdentifierPart were not handled correctly. Now, they are.

(See http://mathiasbynens.be/notes/javascript-identifiers for more information.)

@valueof valueof closed this in 7f694e4 Oct 6, 2013

@valueof

This comment has been minimized.

Show comment
Hide comment
@valueof

valueof Oct 6, 2013

Member

Thank you! I deleted test.js file from your patch seems like it was attached to the patch accidentally.

Member

valueof commented Oct 6, 2013

Thank you! I deleted test.js file from your patch seems like it was attached to the patch accidentally.

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Oct 7, 2013

Contributor

Good catch — sorry about that.

Contributor

mathiasbynens commented Oct 7, 2013

Good catch — sorry about that.

jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

Fixed #1297: Improve Unicode support in the identifier parser
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment