Handle single-line comments for block ignore #1454

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ethul
Contributor
ethul commented Jan 3, 2014

When the block ignore directive is active, it is possible that the
corresponding end ignore directive is written using a single-line
comment.

This means that lines beginning with a single line comment cannot be set
to the empty string value during the ignore directive processing.

References:

Closes issue #1453

@ethul ethul Handle single-line comments for block ignore
When the block ignore directive is active, it is possible that the
corresponding end ignore directive is written using a single-line
comment.

This means that lines beginning with a single line comment cannot be set
to the empty string value during the ignore directive processing.

References:

  Closes issue #1453
013bc98
@valueof valueof added a commit that referenced this pull request Jan 26, 2014
@ethul @valueof ethul + valueof Issue #1453: Handle single-line comments for block ignore (PR #1454)
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
ffa1d92
@valueof
Member
valueof commented Jan 26, 2014

Landed a slightly modified version of your patch. Thanks!

@valueof valueof closed this Jan 26, 2014
@ethul
Contributor
ethul commented Jan 26, 2014

Welcome!

@jugglinmike jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014
@ethul @jugglinmike ethul + jugglinmike Issue #1453: Handle single-line comments for block ignore (PR #1454)
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
09b5088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment