Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

issue #1282: consider relaxing the "maxlen" option in comments for some cases #1464

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

julienw commented Jan 8, 2014

Correctly fix the issue #1282 for multiline comments.

The added test was working because state.tokens.curr.comment was hitting the previous comment, that's why I added a code line between comments in the test, and this showed the issue.

@julienw julienw issue #1282: consider relaxing the "maxlen" option in comments for so…
…me cases

Correctly fix the issue for multiline comments
2b173b0
Contributor

julienw commented Jan 21, 2014

Hey @antonkovalyov, do you think you'll be able to check this simple fix-with-tests soon ? This fixes the wrong implementation I did for issue #1282 in 2.4.0.

Bonus points if you can issue a 2.4.2 release with this in ;)

@valueof valueof added a commit that referenced this pull request Jan 21, 2014

@julienw @valueof julienw + valueof Issue #1464: Correctly fix #1282 (relaxing maxlen for comments)
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
c7959ff
Owner

valueof commented Jan 21, 2014

Merged, will publish in a few.

@valueof valueof closed this Jan 21, 2014

Contributor

nschonni commented Jan 21, 2014

@julienw you might want to do another patch to https://github.com/mdevils/node-jscs since the style rules are moving there for v3

Contributor

julienw commented Jan 22, 2014

@nschonni thanks, I created an issue there for now, I'll try to find time to do it

Contributor

julienw commented Jan 22, 2014

@antonkovalyov thanks a lot !

@jugglinmike jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

@julienw @jugglinmike julienw + jugglinmike Issue #1464: Correctly fix #1282 (relaxing maxlen for comments)
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
63546fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment