Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes jshint exit code vows under windows. #1542

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

aq1018 commented Feb 20, 2014

This fix uses https://www.npmjs.org/package/exit to instead of process.exit and various hacks to accommodate for windows stdio strangeness.

This lib is also used by grunt as a dependency and has been tested by various people to ensure it works across platforms.

This PR should fix the following issues:
#1541
#1408

References for the windows stdio issues:

joyent/node#3584
cowboy/node-exit#4

Testing drain of stdio is not included as this is tested by exit package by various contributors and users already.

Lastly, thanks for the awesome work on JSHint!

Best,

AQ

@valueof valueof added a commit that referenced this pull request Feb 21, 2014

@aq1018 @valueof aq1018 + valueof Issue #1542: Use exit module instead of process.exit. Fixes #1541 and #…
…1408.

Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
121be49

@valueof valueof added a commit that referenced this pull request Feb 21, 2014

@aq1018 @valueof aq1018 + valueof Issue #1542: Use exit module instead of process.exit. Fixes #1541 and #…
…1408.

Signed-off-by: Anton Kovalyov <anton@kovalyov.net>

Conflicts:
	src/cli.js
ed46471
Owner

valueof commented Feb 21, 2014

Thanks!

@valueof valueof closed this Feb 21, 2014

Contributor

aq1018 commented Feb 21, 2014

Thanks so much for accepting my patches. :D Is a release coming any time soon? Thanks in advance!

Contributor

aq1018 commented Feb 21, 2014

Sorry about my previous comment, please disregard, I just saw the 2.4.4 release. Thanks again!

@takueof takueof referenced this pull request in jscs-dev/node-jscs Aug 22, 2014

Closed

Fixes JSCS exit code vows under MS Windows #587

@jugglinmike jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

@aq1018 @jugglinmike aq1018 + jugglinmike Issue #1542: Use exit module instead of process.exit. Fixes #1541 and #…
…1408.

Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
49ddc1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment