Don't throw an error when yield statement used within a catch block inside a generator function #1543

Merged
merged 1 commit into from Mar 21, 2014

Conversation

Projects
None yet
5 participants
Contributor

hiddentao commented Feb 21, 2014

This fixes this issue and adds a parser unit test to ensure it stays fixed.

See jshint/jshint#1505

fengmk2 commented Mar 7, 2014

+1 Need this too.

👍 please let this get in with next release asap.

Owner

rwaldron commented Mar 21, 2014

I don't understand "+1" when this isn't a "feature request" that's up for discussion, it's just a bug that needs to be fixed.

Owner

valueof commented Mar 21, 2014

Thanks! Can you make the same PR for master as well, please?

valueof added a commit that referenced this pull request Mar 21, 2014

Merge pull request #1543 from hiddentao/yield_catch
Don't throw an error when yield statement used within a catch block inside a generator function

@valueof valueof merged commit e3aa718 into jshint:2.x Mar 21, 2014

1 check passed

default The Travis CI build passed
Details

@valueof valueof referenced this pull request Mar 21, 2014

Closed

PRs that need to be merged into master #1579

2 of 6 tasks complete

hiddentao added a commit to hiddentao/jshint that referenced this pull request Mar 29, 2014

@hiddentao hiddentao deleted the hiddentao:yield_catch branch Mar 29, 2014

Contributor

hiddentao commented Mar 29, 2014

@antonkovalyov PR for master raised in #1596

jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

Merge pull request #1543 from hiddentao/yield_catch
Don't throw an error when yield statement used within a catch block inside a generator function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment