Allow multiple filenames to be passed to Rhino CLI #313

Merged
merged 3 commits into from Oct 25, 2011

Conversation

Projects
None yet
2 participants
@nzakas
Contributor

nzakas commented Oct 19, 2011

This patch allows multiple filenames to be passed to the Rhino CLI. When checking multiple files, you end up starting up and tearing down a JVM for every single file, which adds a significant amount of time to the overall linting process. By allowing the Rhino CLI to process multiple files, you can dramatically reduce the total amount of time for processing a large number of files.

When I made this change to the CSSLint JSHint task, it went from taking 45s to check the entire source tree to 3s.

I tried to ensure backwards compatibility with the current CLI, and believe everything still works the same way. The only difference is that any value passed on the command line without an = sign is considered to be a filename.

valueof added a commit that referenced this pull request Oct 25, 2011

Merge pull request #313 from nzakas/master
Allow multiple filenames to be passed to Rhino CLI

@valueof valueof merged commit 3c37587 into jshint:master Oct 25, 2011

@valueof

This comment has been minimized.

Show comment Hide comment
@valueof

valueof Oct 25, 2011

Owner

Thanks!

Owner

valueof commented Oct 25, 2011

Thanks!

jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

Merge pull request #313 from nzakas/master
Allow multiple filenames to be passed to Rhino CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment