Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[FEAT]] Add support for ES2019 opt. catch param #3418

Closed
wants to merge 2 commits into from

Conversation

@jugglinmike
Copy link
Member

commented Jul 21, 2019

No description provided.

@jugglinmike jugglinmike requested a review from rwaldron Jul 21, 2019

@caitp
caitp approved these changes Jul 21, 2019
Copy link
Member

left a comment

looks good here

state.option.moz = false;
state.option.esversion = +val;
break;
case "2015":
case "2016":
case "2017":
case "2018":
case "2019":

This comment has been minimized.

Copy link
@caitp

caitp Jul 21, 2019

Member

side note: I wonder if we should do something similar to babel, marking individual features as allowed/disallowed, and having modules containing presets based on spec versions. These numbers mean less each year in the new living standard model.

This comment has been minimized.

Copy link
@jugglinmike

jugglinmike Aug 23, 2019

Author Member

@caitp When you say "modules," do you mean "npm modules" (i.e. published separately) or "Node.js modules" (i.e. published within this project)?

@rwaldron

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@jugglinmike I only quickly looked at the failures and noted that they are definitely coming from the tests themselves

@jugglinmike

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@rwaldron Right you are. I've pushed up a correction

@coveralls

This comment has been minimized.

Copy link

commented Aug 23, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 5364f51 on jugglinmike:es2019-optional-catch into 1295f3e on jshint:v2.11.0.

@rwaldron

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

  • Rebased fixup!
  • Merged into v2.11.0: ec71bc0

@rwaldron rwaldron closed this Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.