New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: an array of regexes does not pass lint. #792

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@samuelcole
Copy link
Contributor

samuelcole commented Dec 31, 2012

This code passes on jshint.com on 12/31/12, and it looks ok to me.

Failing test: an array of regexes does not pass lint.
This code passes on jshint.com on 12/31/12.
@samuelcole

This comment has been minimized.

Copy link
Contributor

samuelcole commented Dec 31, 2012

Is this a good way to submit unexpected errors in JSHint 1.0.0? I feel like I'm being helpful?

@samuelcole

This comment has been minimized.

Copy link
Contributor

samuelcole commented Dec 31, 2012

Also that Travis build should have failed, I think the make.js script needs to return non-zero when tests fail.

@valueof

This comment has been minimized.

Copy link
Member

valueof commented Dec 31, 2012

This is a good way. Although I'd just create a ticket with a test in it—since I won't be able to merge this pull request without me fixing the issue first.

Thanks!

@samuelcole

This comment has been minimized.

Copy link
Contributor

samuelcole commented Dec 31, 2012

By the way, all of @kickstarter passes (as it does in JSHint r12) except for mailcheck.js: https://gist.github.com/4422742, which has 23 errors.

Right now I'm assuming it's all fallout from that array of Regexes...

@valueof valueof closed this in a7da467 Dec 31, 2012

@samuelcole

This comment has been minimized.

Copy link
Contributor

samuelcole commented Dec 31, 2012

Thanks!

@valueof

This comment has been minimized.

Copy link
Member

valueof commented Dec 31, 2012

Added your test case and fixed this bug.

By the way, all of @kickstarter passes (as it does in JSHint r12) except for mailcheck.js: https://gist.github.com/4422742, which has 23 errors.

Sweet, glad to hear.

@valueof

This comment has been minimized.

Copy link
Member

valueof commented Dec 31, 2012

I just ran your gist locally and it passes without any errors.

jugglinmike added a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment