Withcs #966

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants

levsa commented Mar 26, 2013

Included the checkstyle reporter in the bundle so that it can be used in rhino environment. Also updating the gradle-js-plugin so that jshint can be used to generate checkstyle reports to be parsed by jenkins after builds.

Made minor change to the checkstyle reporter to be able to print instead of using process.stdout.

Had to create a fake console to handle error prints from the event package about event listener memory leaks, because listeners doesn't seem to be removed when too many files are given as input to jshint. That issue needs to be addressed by someone who knows how.

Contributor

guyzmo commented Mar 28, 2013

Had to create a fake console to handle error prints from the event package about event listener memory leaks, because listeners doesn't seem to be removed when too many files are given as input to jshint. That issue needs to be addressed by someone who knows how.

you should create an issue about that

Owner

valueof commented Mar 28, 2013

you should create an issue about that

There's already GH-931.

Owner

valueof commented Apr 8, 2013

Thanks but I'd rather just add support for any reporter, similar to what we have in a Node version.

valueof closed this Apr 8, 2013

levsa commented Apr 8, 2013

It is easy (easier) to add support for all available reporters given this patch.

Owner

valueof commented Apr 8, 2013

Well, for starters this patch replaces console-browserify we use with a hand-rolled shim. It also bumps package version which is a no-go (I bump versions as a last commit of a tagged release).

levsa commented Apr 8, 2013

Oops, sorry about the version. The purpose of this patch was to generate a new jshint-rhino package to use in "gradle-js-plugin", instead of patching the one there. But I ended up with patching that one anyway (jshint-rhino-r12) because of performance issues with this last one.

Yes, the console-browserify issue needs to be resolved. I don't know enough about the environment for jshint to understand the problem. If someone could help out with a solution, I can switch back to console-browserify.

For now, my patches in gradle-js-plugin works fine for us. But for future versions, it would be better if the reporter support was in place in the generated rhino package of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment