Skip to content

Loading…

Fix comment in jshint defaults file #134

Closed
wants to merge 1 commit into from

2 participants

@leocassarani

The comment explaining the forin option in the defaults.json file was referencing hasOwnPrototype, instead of hasOwnProperty.

I'm guessing this was a typo, as the JSHint documentation states that
the forin option requires loops to be filtered with hasOwnProperty.

@leocassarani leocassarani Fix comment in jshint defaults file
The comment explaining the "forin" option in the defaults.json
file was referencing hasOwnPrototype, instead of hasOwnProperty.

I'm guessing this was a typo, as the JSHint documentation states that
the "forin" option requires loops to be filtered with hasOwnProperty:

http://www.jshint.com/docs/
a36f6d8
@brentlintner
JSHint member

Thanks for the contribution! :-) However this project has been folded into jshint/jshint, so please issue this into that repo (if it is still applicable).

@leocassarani

Ah, thank you. Silly me for not reading the README first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 27, 2012
  1. @leocassarani

    Fix comment in jshint defaults file

    leocassarani committed
    The comment explaining the "forin" option in the defaults.json
    file was referencing hasOwnPrototype, instead of hasOwnProperty.
    
    I'm guessing this was a typo, as the JSHint documentation states that
    the "forin" option requires loops to be filtered with hasOwnProperty:
    
    http://www.jshint.com/docs/
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1 example/defaults.json
View
2 example/defaults.json
@@ -72,7 +72,7 @@
"evil": false,
// Whether ExpressionStatement should be allowed as Programs.
"expr": false,
- // Whether `for in` loops must filter with `hasOwnPrototype`.
+ // Whether `for in` loops must filter with `hasOwnProperty`.
"forin": false,
// Whether immediate invocations must be wrapped in parens, e.g.
// `( function(){}() );`.
Something went wrong with that request. Please try again.