Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #762 #767

Merged
merged 10 commits into from Nov 22, 2019
Merged

Resolve #762 #767

merged 10 commits into from Nov 22, 2019

Conversation

jshjohnson
Copy link
Collaborator

@jshjohnson jshjohnson commented Nov 19, 2019

Description

This addresses an issue raised in #762 where the value of a key press was not reflected in the input when the input is not focussed.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 19, 2019
@jshjohnson jshjohnson changed the title Implement #762 Resolve #762 Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #767 into master will increase coverage by 0.93%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   66.56%   67.49%   +0.93%     
==========================================
  Files          22       22              
  Lines        1319     1323       +4     
==========================================
+ Hits          878      893      +15     
+ Misses        441      430      -11
Impacted Files Coverage Δ
src/scripts/choices.js 55.86% <66.66%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f0b5f...873a16a. Read the comment docs.

@jshjohnson jshjohnson merged commit 67266a3 into master Nov 22, 2019
@jshjohnson jshjohnson deleted the implement-762 branch November 22, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant