Incorrect URL and ICS generation when alternate format is used #31

Closed
bignall opened this Issue Oct 12, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@bignall
Contributor

bignall commented Oct 12, 2016

  • It generates the URLs before it generates the dates using the specified format so the URLs don't have the right format (which is probably okay because google/yahoo/microsoft calendars seem to figure out most formats anyway).
  • The ICS uses the start and end dates specified in the scope not the dates generated in the format function which may not be the right format for ICS (probably isn't if an alternate format is used)
  • The format string is ignored because it's not in the scope of the controller (the directive doesn't have it in the scope)

I've fixed these and a PR is in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment