return __false__ when request includes Cache-Control: no-cache #2

Merged
merged 2 commits into from Aug 10, 2013

4 participants

@paulwalker

In order to force a response body despite conditional cache header values, as is appropriate per rfc. see: http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.2.6

@ggoodman

I agree that this would be great. I'm having a tough time how to prevent express from sending a 304 when I don't want it to.

My requests are '"Cache-Control:max-age=0" and "Pragma:no-cache" but still come back with 304s.

For my json api, this means that link headers are not getting through and so pagination is failing.

@paulwalker

Any chance of getting this pulled?

@tj
tj commented Aug 10, 2013

@ggoodman that brings up a good point though, because we should be hashing header fields as well for the etag

@tj tj merged commit e9d2d60 into jshttp:master Aug 10, 2013
@paulwalker paulwalker deleted the paulwalker:no-cache branch Aug 10, 2013
@dougwilson dougwilson added the pr label Dec 21, 2014
@tj tj added a commit that referenced this pull request May 12, 2015
@paulwalker paulwalker Check for no-cache cache request directive
fixes #2
c6eb52b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment