Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to support media-typer ≥ 1.0.0 #43

Closed
wants to merge 1 commit into from

Conversation

guimard
Copy link

@guimard guimard commented Nov 21, 2019

Hi,

a little patch to be able to use media-typer ≥ 1.0.0

@dougwilson
Copy link
Contributor

I believe this is already covered in the develop branch https://github.com/jshttp/type-is/commits/develop

Is this an alternative solution that should be considered over what is already landed?

@guimard
Copy link
Author

guimard commented Nov 21, 2019

Sorry, I didn't see this branch. This patch started from master.
Cheers,
Xavier

@dougwilson
Copy link
Contributor

Looks like CI does not pass on this PR if you want to look into it. Let me know additionally the answer to my question above :)

@guimard
Copy link
Author

guimard commented Nov 21, 2019

I don't understand what happens with travis, looks good here...

@dougwilson
Copy link
Contributor

I can help look into it, but ideally if I could get the answer for if this is relevant or not first would help know if it's worth fixing.

@guimard
Copy link
Author

guimard commented Nov 21, 2019

You can close this issue, I'll update Debian package when next release will be out.

Thanks!

@helio-frota
Copy link

You can close this issue, I'll update Debian package when next release will be out.

Hi,
Closing this pull request as part of triage process.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants