Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test disconnection in test_connection.py #1520

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
3 participants
@wkentaro
Copy link
Member

wkentaro commented Apr 23, 2017

Close #1519

  • modified: test/test_connection.py
Test disconnection in test_connection.py
- modified:   test/test_connection.py

@wkentaro wkentaro force-pushed the wkentaro:test_connection_disappears branch from acc092c to 6b70f34 Apr 28, 2017

@wkentaro wkentaro self-assigned this Apr 28, 2017

@wkentaro

This comment has been minimized.

Copy link
Member Author

wkentaro commented Apr 29, 2017

It fails on hydro.

[jsk_topic_tools] [ROSTEST]----------------------------------------------------------------------- 

[jsk_topic_tools]  

[jsk_topic_tools] [jsk_topic_tools.rosunit-test_connection/test_no_subscribers][passed] 

[jsk_topic_tools] [jsk_topic_tools.rosunit-test_connection/test_subscriber_appears_disappears][ERROR] 

[jsk_topic_tools] Found topic: input 

[jsk_topic_tools]   File "/usr/lib/python2.7/unittest/case.py", line 327, in run 

[jsk_topic_tools]     testMethod() 

[jsk_topic_tools]   File "/workspace/ros/ws_jsk_common/src/jsk_common/jsk_topic_tools/test/test_connection.py", line 62, in test_subscriber_appears_disappears 

[jsk_topic_tools]     raise ValueError('Found topic: {}'.format(check_topic)) 

[jsk_topic_tools] -------------------------------------------------------------------------------- 

[jsk_topic_tools]  

[jsk_topic_tools]  

[jsk_topic_tools] SUMMARY 

[jsk_topic_tools]  * RESULT: FAIL 

[jsk_topic_tools]  * TESTS: 2 

[jsk_topic_tools]  * ERRORS: 1 

[jsk_topic_tools]  * FAILURES: 0 

@wkentaro wkentaro requested a review from iory Apr 29, 2017

@iory

iory approved these changes May 15, 2017

@wkentaro

This comment has been minimized.

Copy link
Member Author

wkentaro commented May 15, 2017

Please merge this.

@k-okada k-okada merged commit 5e0316b into jsk-ros-pkg:master May 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.