Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_topic_tools][connection_based_nodelet] add isSubscribed method #1523

Merged
merged 1 commit into from
May 31, 2017

Conversation

furushchev
Copy link
Member

To see current subscribing state of a nodelet.

Copy link
Member

@wkentaro wkentaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not place the implementation in .cpp not header?

@wkentaro wkentaro self-assigned this May 29, 2017
@furushchev
Copy link
Member Author

@wkentaro I think it's better to define as inline method. Is it better to define in .cpp?

@wkentaro
Copy link
Member

@wkentaro I think it's better to define as inline method. Is it better to define in .cpp?

Fine by me.

[jsk_topic_tools][ConnectionBasedTransport] add is_subscribed method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants