Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_tools] add ROS param set test #1535

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Projects
None yet
3 participants
@knorth55
Copy link
Member

commented Jun 27, 2017

Usage

name: param name
timeout: timeout [second]
expected: expected value
<test test-name="rosparam_set"
      pkg="jsk_tools" type="test_rosparam_set.py">
  <rosparam>
    params
      - name: /test_param
        expected: true
        timeout: 10
  </rosparam>
<test>

@knorth55 knorth55 requested a review from wkentaro Jun 27, 2017

@wkentaro
Copy link
Member

left a comment

I found we can use list of dict instead of using ~param_0, ... ~param_N.
Please refer to https://github.com/ros/ros_comm/blob/lunar-devel/tools/rostest/nodes/publishtest#L41 .

And please consider sending PR to rostest when you have tim.
It has node for single param test: https://github.com/ros/ros_comm/blob/lunar-devel/tools/rostest/nodes/paramtest

@knorth55 knorth55 force-pushed the knorth55:add-rosparam-test branch from f73abee to 964026d Jun 28, 2017

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

updated!

<test test-name="rosparam_set"
      pkg="jsk_tools" type="test_rosparam_set.py">
  <rosparam>
    params
      - name: /test_param
        expected: true
        timeout: 10
  </rosparam>
<test>

@wkentaro wkentaro added the feature label Jun 28, 2017

@k-okada k-okada merged commit 8d8cece into jsk-ros-pkg:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@knorth55 knorth55 deleted the knorth55:add-rosparam-test branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.