Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsk_topic_tools: add option to display diagnostic messages on warning level #1585

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
3 participants
@furushchev
Copy link
Contributor

commented Jun 20, 2018

This PR adds ~use_warning parameter to display diagnostic messages on warning level instead of error level on DiagnosticNodelet.

@furushchev

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2018

The name ~use_warning is too general, so any discussion is very welcome.

@furushchev

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2018

jsk_topic_tools: add option to set diangostic level
jsk_topic_tools: update doc for jsk_topic_tools nodelet classes

@furushchev furushchev force-pushed the furushchev:warning-diagnostic branch from baaf908 to 6c6c6c7 Jun 21, 2018

@furushchev

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

After discussion with active users, I changed to use /diagnostic_nodelet/use_warn for global ns, and ~use_warn in local ns to set diagnostic status level on non OK status.

@furushchev furushchev requested a review from wkentaro Jun 21, 2018

@k-okada k-okada merged commit 27f26b8 into jsk-ros-pkg:master Jun 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@furushchev furushchev deleted the furushchev:warning-diagnostic branch Jun 26, 2018

@furushchev furushchev added this to the 2.2.7 milestone Jun 26, 2018

@furushchev

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2018

Added to milestone for possible next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.