Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaskImageToPointIndices: support multi channel mask image #2409

Merged
merged 13 commits into from Apr 30, 2019

Conversation

furushchev
Copy link
Member

No description provided.

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the document too

@furushchev
Copy link
Member Author

Updated.

Copy link
Member

@knorth55 knorth55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update output msg type in doc?
if you choose use_multi_channel:=true and target_index:=-1, ~output message type would be ClusterPointIndices

@knorth55
Copy link
Member

Or you can use different topic namespace for the specific case.

@YutoUchimi
Copy link
Contributor

I use different topic name. i.e. ~output for pcl_msgs/PointIndices and ~output/all_indices for jsk_recognition_msgs/ClusterPointIndices.

@YutoUchimi
Copy link
Contributor

YutoUchimi commented Apr 18, 2019

Hmm... travis test is unstable.
https://travis-ci.org/jsk-ros-pkg/jsk_recognition/jobs/521082606

[ROSTEST]-----------------------------------------------------------------------
[jsk_pcl_ros_utils.rosunit-test_mask_image_to_point_indices/test_published][FAILURE]
Topic [/mask_image_to_point_indices2/output/all_indices] is not published
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/opt/ros/melodic/share/jsk_tools/src/test_topic_published.py", line 96, in test_published
    checker.topic_name)
  File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
    raise self.failureException(msg)
--------------------------------------------------------------------------------
SUMMARY
 * RESULT: FAIL
 * TESTS: 1
 * ERRORS: 0
 * FAILURES: 1
rostest log file is in /workspace/jsk-ros-pkg/jsk_recognition/log/rostest-812380ba91e4-24665.log
-- run_tests.py: verify result "/workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros_utils/test_results/jsk_pcl_ros_utils/rostest-test_mask_image_to_point_indices.xml"
make[3]: Leaving directory '/workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros_utils'
Built target _run_tests_jsk_pcl_ros_utils_rostest_test_mask_image_to_point_indices.test

@YutoUchimi
Copy link
Contributor

Travis passed!
@knorth55 Could you review again?

@YutoUchimi YutoUchimi changed the title MaskImageToPointIndices: support multi channel mask image [WIP] MaskImageToPointIndices: support multi channel mask image Apr 29, 2019
@YutoUchimi
Copy link
Contributor

YutoUchimi commented Apr 29, 2019

Before 9df55df

The invalid output shown below was caused by JPEG compression of original images (kiva_pod_mask.jpg and circles.jpg). The images may contain some values other than 0 or 255.

mask_image_to_point_indices_no_jpg_support

After 9df55df

I increased the threshold from 0 to 127 in order to support JPEG images as much as possible.

mask_image_to_point_indices

@YutoUchimi YutoUchimi changed the title [WIP] MaskImageToPointIndices: support multi channel mask image MaskImageToPointIndices: support multi channel mask image Apr 29, 2019
@k-okada k-okada merged commit 4d9ca7c into jsk-ros-pkg:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants