Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major Release] Remove extract_images_sync that merged in image_view #1633

Merged
merged 1 commit into from Oct 27, 2016

Conversation

Projects
None yet
2 participants
@wkentaro
Copy link
Member

commented Apr 29, 2016

No description provided.

@k-okada

This comment has been minimized.

Copy link
Member

commented May 1, 2016

@wkentaro wkentaro added the enhancement label May 7, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch 3 times, most recently from c118c89 to d8b200e May 7, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from d8b200e to 8a0e37b May 16, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented May 18, 2016

PLZ merge this.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

plz merge

@k-okada

This comment has been minimized.

Copy link
Member

commented May 19, 2016

I think we need to wait for #1633 (comment)

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

Ok.

@wkentaro wkentaro changed the title [jsk_perception] Remove extract_images_sync that merged in image_view Remove extract_images_sync that merged in image_view May 28, 2016

@wkentaro wkentaro self-assigned this Jun 1, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from 8a0e37b to 92e5f84 Jul 31, 2016

@k-okada k-okada referenced this pull request Aug 1, 2016

Closed

[doc/jsk_perception] add documentation #1648

19 of 19 tasks complete

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from 92e5f84 to 75fd557 Aug 20, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from 75fd557 to 24dffa7 Sep 1, 2016

@wkentaro wkentaro changed the title Remove extract_images_sync that merged in image_view [Major Release] Remove extract_images_sync that merged in image_view Sep 17, 2016

@wkentaro wkentaro added this to the 0.4.0 milestone Sep 17, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from 24dffa7 to 7dc22b0 Sep 21, 2016

@wkentaro wkentaro force-pushed the wkentaro:remove-extract-images-sync branch from 7dc22b0 to bb8c08a Oct 10, 2016

@k-okada

This comment has been minimized.

Copy link
Member

commented Oct 27, 2016

can we merge even if ros-perception/image_pipeline#164 is not merged yet?

@k-okada k-okada added the PR/MergeOK label Oct 27, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2016

Yeah, I think so.
I will revise the current extract_image_sync in image_view to have a feature in image_save_sync.

@k-okada k-okada merged commit 2e4ea0f into jsk-ros-pkg:master Oct 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wkentaro wkentaro deleted the wkentaro:remove-extract-images-sync branch Oct 27, 2016

wkentaro referenced this pull request Oct 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.