Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve topic name visualization in tile_image.py #2256

Merged
merged 3 commits into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@wkentaro
Copy link
Member

commented Apr 3, 2018

  • Use FONT_HERSHEY_SIMPLEX.
  • Adjust font_scale according to the new font.

Before

After

Improve visualization in tile_image.py
- Use FONT_HERSHEY_SIMPLEX.
- Adjust font_scale according to the new font.

@wkentaro wkentaro self-assigned this Apr 3, 2018

@wkentaro wkentaro added the enhancement label Apr 3, 2018

@wkentaro wkentaro changed the title Improve visualization in tile_image.py Improve topic name visualization in tile_image.py Apr 3, 2018

@wkentaro wkentaro requested review from knorth55 and YutoUchimi Apr 3, 2018

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2018

Had error described in #2258.
I commented out it for now.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2018

@k-okada could you merge this?

@k-okada k-okada merged commit 5b29f1a into jsk-ros-pkg:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wkentaro wkentaro deleted the wkentaro:improve_tile_image branch Apr 5, 2018

@wkentaro wkentaro modified the milestones: 1.2.6, 1.2.5 Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.