Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baxtereus] Fix bug to pass args in :angle-vector #729

Merged
merged 4 commits into from Nov 21, 2016

Conversation

Projects
None yet
2 participants
@knorth55
Copy link
Member

commented Nov 19, 2016

Main Change

  • fix bug in angle-vector

use :move-arm as key and pass other args to other methods
currently args passing was not proper (actually tm was not passed properly)

usage of angle-vector in robot-interface is as below.
(send *ri* :angle-vector tm)

Therefore, for compatibility, set :move-arm as key.
(send *ri* :angle-vector av tm :move-arm :rarm)

and we can use existing usage of :angle-vector as below
(send *ri* :angle-vector av 3000 nil 0)

Minor Changes

  • refine warning messages
  • remove tab and use space in baxter-interface
  • fix typo in baxter-interfacel.l

@knorth55 knorth55 changed the title [baxtereus] Fix bug in :angle vector [baxtereus] Fix bug to pass args in :angle-vector Nov 19, 2016

@knorth55 knorth55 force-pushed the knorth55:fix-bug-angle-vector branch from c9ec887 to d3de46e Nov 19, 2016

fix bug in :angle-vector
use :move-arm as key and pass other args to other methods
currently args passing was not proper

@knorth55 knorth55 force-pushed the knorth55:fix-bug-angle-vector branch from d3de46e to f6fab53 Nov 19, 2016

@k-okada k-okada merged commit 3fb5bc1 into jsk-ros-pkg:master Nov 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@knorth55 knorth55 deleted the knorth55:fix-bug-angle-vector branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.