Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Notify roslint results to PR webpage #219

Closed
wants to merge 17 commits into from

Conversation

Projects
None yet
3 participants
@wkentaro
Copy link
Member

commented Dec 17, 2015

@furushchev
Could you please notify to PR in notify_roslint_results.py ?

Modified:
travis.sh
Added:
added_lines.sh
notify_roslint_results.py

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Dec 17, 2015

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

ERROR: cannot download default sources list from:

https://raw.github.com/ros/rosdistro/master/rosdep/sources.list.d/20-default.list

Website may be down.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

sample output of diff.patch and roslint_result.txt.
https://gist.github.com/ba16ad862f380d2e689e

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

['/home/wkentaro/ros/indigo/src/jsk-ros-pkg/jsk_common/jsk_topic_tools/src/hz_measure_nodelet.cpp:57:  Missing spaces around >  [whitespace/operators] [3]']

is output of notify_roslint_result.py currently.

@furushchev

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2015

<file path="">
<warn commit="" line="">error_message</warn>
...
</file>

の形式が良いです。

@furushchev

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2015

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from 5caa85b to 3bcd764 Dec 17, 2015

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

example output:

<roslint>
 <remote>
  <github owner="jsk-ros-pkg" repository="jsk_common" pullrequest="1312" />
 </remote>
 <result>
  <file path="jsk_topic_tools/src/hz_measure_nodelet.cpp" commit="75c4a10">
   <error line="57">Missing spaces around >  [whitespace/operators] [3]</error>
  </file>
 </result>
</roslint>
@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

@furushchev done.

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Dec 17, 2015

[jsk_topic_tools] Stop using roslint as test
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/CMakeLists.txt

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Dec 17, 2015

TEST COMMIT: test for roslint report
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/src/hz_measure_nodelet.cpp
@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

above xml is expected output in jsk-ros-pkg/jsk_common#1312

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch 3 times, most recently from 28fbb3e to ab711b5 Dec 17, 2015

@wkentaro wkentaro changed the title [WIP] Notify roslint results to PR webpage Notify roslint results to PR webpage Dec 18, 2015

@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

too many y output

@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

I think this jenkins job kills other jobs

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2015

oops, sorry I will fix it.

@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

23:30:21 travis_time_end
23:30:23 Error response from daemon: database or disk is full
@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

$ df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/sda1       424G  263G  140G  66% /
udev             63G  4.0K   63G   1% /dev
tmpfs            13G  1.1M   13G   1% /run
none            5.0M     0  5.0M   0% /run/lock
none             63G   15M   63G   1% /run/shm
cgroup           63G     0   63G   0% /sys/fs/cgroup
/dev/sdb1       550G  146G  377G  28% /export/data1
/dev/sdc1       550G  550G     0 100% /export/data2
/dev/sdd1       550G  483G   40G  93% /export/data3

/dev/sdc is full

@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

@k-okada Could you cleanup /export/data2?

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2015

I'm sorry..

@garaemon

This comment has been minimized.

Copy link
Member

commented Dec 18, 2015

I don't know why /export/data2/docker directory is so huge...

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from 6757726 to 523d174 Dec 21, 2015

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Dec 21, 2015

TEST COMMIT: test for roslint report
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/src/hz_measure_nodelet.cpp

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from 523d174 to c76bdc9 Dec 21, 2015

@wkentaro wkentaro changed the title Notify roslint results to PR webpage [WIP] Notify roslint results to PR webpage Apr 23, 2016

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from 57f6a48 to 2f918d1 Apr 23, 2016

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Apr 23, 2016

TEST COMMIT: test for roslint report
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/src/hz_measure_nodelet.cpp

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from 2f918d1 to f98c424 Apr 24, 2016

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Apr 27, 2016

TEST COMMIT: test for roslint report
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/src/hz_measure_nodelet.cpp

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from ec00884 to d6b820a Apr 27, 2016

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch 2 times, most recently from bbde0fa to ba680a3 Apr 27, 2016

@wkentaro wkentaro force-pushed the wkentaro:notify-roslint-result branch from ba680a3 to 2edd619 May 5, 2016

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request May 25, 2016

TEST COMMIT: test for roslint report
Need jsk-ros-pkg/jsk_travis#219

Modified:
	 jsk_topic_tools/src/hz_measure_nodelet.cpp
@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2016

Closing with same comment: jsk-ros-pkg/jsk_common#1312 (comment)

@wkentaro wkentaro closed this Jun 6, 2016

@wkentaro wkentaro deleted the wkentaro:notify-roslint-result branch Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.